[client] Add NB_SKIP_SOCKET_MARK & fix crash instead of returing an error - Githubissues

netbirdio / netbird

Connect your devices into a secure WireGuard®-based overlay network with SSO, MFA and granular access controls.

https://netbird.io

BSD 3-Clause "New" or "Revised" License

11.24k stars 517 forks source link

[client] Add NB_SKIP_SOCKET_MARK & fix crash instead of returing an error #2899

Closed nazarewk closed 2 days ago

nazarewk commented 4 days ago

Describe your changes

I found some changes laying around on my computer when asked about #2530 (debugging my mobile router), can as well upstream those:

allows disabling SO_MARK without disabling other custom routing features
makes dialer return an error instead of crashing the process with log.Fatalf

Issue ticket number and link

https://github.com/netbirdio/netbird/issues/2530

Checklist

[x] Is it a bug fix
[ ] Is a typo/documentation fix
[x] Is a feature enhancement
[ ] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

nazarewk commented 3 days ago

I am not sure what is it with failing tests, doesn't seem like failures are related to my changes.

lixmal commented 3 days ago

I am not sure what is it with failing tests, doesn't seem like failures are related to my changes.

Can you merge main? There's been an issue with a domain for the tests

sonarcloud[bot] commented 3 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lixmal commented 2 days ago

Thanks a lot