netblue30 / fdns

Firejail DNS-over-HTTPS Proxy Server
GNU General Public License v3.0
121 stars 30 forks source link

configure logic potentially breaks apparmor and systemd unit #49

Open glitsj16 opened 3 years ago

glitsj16 commented 3 years ago

After a few recent commits (https://github.com/netblue30/fdns/commit/ab483585b3050ac8338ad27d3f6ab357ee9cf05d and https://github.com/netblue30/fdns/commit/318ee24ae32cb5898687333e52b6bb2ce18e3553) it dawned on me that our configure logic seems to assume --prefix=/usr is present. If that prefix is absent (which is the default if not explicitly added when packaging), things start to break rather badly. Especially the apparmor files and the systemd unit are affected.

Let's check what happens when a user uses ./configure --enable-apparmor:

Problems:

IMHO we should improve the current configuration logic and avoid such breakage.

netblue30 commented 3 years ago

OK, for now we will document them. BTW, we have the same problem in Firejail with apparmor.