netblue30 / firejail

Linux namespaces and seccomp-bpf sandbox
https://firejail.wordpress.com
GNU General Public License v2.0
5.72k stars 559 forks source link

Firejail doesn't hide set secrets #3352

Open mustaqimM opened 4 years ago

mustaqimM commented 4 years ago

Describe the bug The application (aria2) sets the secret which normally shows as stars, but when run with firejail, it gets exposed: image

Behavior change on disabling firejail N/A

To Reproduce Steps to reproduce the behavior:

  1. Run with the command: firejail aria2c --rpc-secret=${RPC_SECRET}
  2. See error

Expected behavior If possible, firejail should also obfuscate the secret set by the application

Desktop (please complete the following information):

Compile time support:

matu3ba commented 4 years ago

Does aria2 interact with other programs for this feature and (if you know) in what ways?
What is the output of firejail --debug?

rusty-snake commented 4 years ago

What is the output of firejail --debug?

Why? Its completely unrelated.

Does aria2 interact with other programs for this feature and (if you know) in what ways?

I thing they do some hacks in /proc/self.

rusty-snake commented 4 years ago

IDK if we ever want to implement this, because we would need to parse childs args.

labelling as "enhancement" for now.