Desktop Entry: firecfg --fix can not distinguish firefox, firefox-nightly, firefox-developer-edition,...

[geekshen8521]

Write clear, concise and in textual form.

Bug and expected behavior

• Describe the bug. With firefox, firefox-nightly, firefox-developer-edition installed. firecfg --fix generates firefox-*.desktop file where each "Exec" part of the desktop file contains the same "firefox", instead of firefox-nightly, firefox-developer-edition as they should be. Now all desktop files launches the same firefox version.
• What did you expect to happen? The Exec part of each firefox version should be different according to their firefox versions.
• Running firefox firefox-nightly firefox-developer-edition directly in terminal produce no such problem.

Reproduce Steps to reproduce the behavior:

1. install firefox alongside with other firefox versions (e.g. firefox-developer-edition, firefox-nightly, ...)
2. Run firecfg --fix
3. cd ~/.local/share/applications
4. check each firefox-*.desktop

Environment

• Linux distribution and version (ie output of lsb_release -a, screenfetch or cat /etc/os-release) Name="Arch Linux" Kernel=5.11.2-arch1-1
• Firejail version (output of firejail --version) exclusive or used git commit (git rev-parse HEAD) firejail-git r6994.8a7b96974-1 (from AUR) Additional context firefox firefox-developer-edition (official repo, latest version) firefox-nightly (AUR) firecfg --fix only generate firefox firefox-developer-edition firefox-nightly desktop files. And only these three are influenced.

Checklist

• [ ] The profile (and redirect profile if exists) hasn't already been fixed upstream.
• [x] The program has a profile. (If not, request one in https://github.com/netblue30/firejail/issues/1139)
• [x] I have performed a short search for similar issues (to avoid opening a duplicate).
• [ ] If it is a AppImage, --profile=PROFILENAME is used to set the right profile.
• [ ] Used LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 PROGRAM to get english error-messages.
• [ ] I'm aware of browser-allow-drm yes/browser-disable-u2f no in firejail.config to allow DRM/U2F in browsers.

debug output

[geekshen8521]

I have read the man page, and desktop files in /usr/share/applications are like these: Exec=/usr/lib/firefox-developer-edition/firefox %u Exec=/opt/firefox-nightly/firefox %u I guess may be this is the reason.

[rusty-snake]

Looks like firecfg strips absolute paths even if they aren't in $PATH.

[rusty-snake]

Workaround

Because firecfg does not override existing files in ~/.local/share/applications, you can copy those dot-desktop files and prepend /usr/bin/firejail on all Exec= lines.

for ffxdd in /usr/share/applications/firefox-*.desktop; do
    sed "s|Exec=|Exec=/usr/bin/firejail |g" "$ffxdd" > ~/.local/share/applications/"$(basename "$ffxdd")"
done

or as oneliner:

for ffxdd in /usr/share/applications/firefox-*.desktop; do sed "s|Exec=|Exec=/usr/bin/firejail |g" "$ffxdd" > ~/.local/share/applications/"$(basename "$ffxdd")"; done

[geekshen8521]

Thanks @rusty-snake Another workaround is to simply edit the desktop files under ~/.local/share/applications accordingly. And make sure that in PATH variable, /usr/local/bin precedes /usr/bin/.