search

netblue30 / firejail

Linux namespaces and seccomp-bpf sandbox
https://firejail.wordpress.com
GNU General Public License v2.0
5.8k stars 567 forks source link

gitlab-ci: Automatically run CI checks for all applicable GitHub PRs #5149

Open kmk3 opened 2 years ago

kmk3 commented 2 years ago

Pipelines were executed for pull requests that have no relevance to GitLab CI, such as the following ones about updating the versions of GitHub Actions:

->

But they were not executed for the following pull requests that actually change the code and/or .gitlab-ci.yml:

@Fred-Barclay @reinerh

kmk3 commented 2 years ago

Also, can someone add me (same username) to the GitLab project so that I can debug the CI there?

reinerh commented 2 years ago

Also, can someone add me (same username) to the GitLab project so that I can debug the CI there?

invite sent.

kmk3 commented 2 years ago

@reinerh commented on May 17:

Also, can someone add me (same username) to the GitLab project so that I can debug the CI there?

invite sent.

Thanks!

kmk3 commented 2 years ago

Regarding the PRs, it looks like the default rule on GitLab CI is something like "always build on (first-party) branch creation/modification", which by default would include master and any other branches that exist in this repository (and any branch that is pushed only to the mirror).

Since dependabot creates the branches directly in this repository (rather than in a fork), all of its branches also get tested. But branches from forks are not copied over to the GitLab mirror when a PR is opened, so they are not tested.

So it should be simple to ignore dependabot PRs based on paths changed or on branch name, but automatically building PRs opened from forks seems trickier.

I see now that this feature is actually being tracked by GitLab:

Main issue:

Related issues:

To anyone reading this, please consider voting on the main issue if you think it would be useful (it's at +77/-0 votes as of writing).