netblue30 / firejail

Linux namespaces and seccomp-bpf sandbox
https://firejail.wordpress.com
GNU General Public License v2.0
5.84k stars 568 forks source link

PCSX2: profile needs to be converted for appimages #5738

Open NetSysFire opened 1 year ago

NetSysFire commented 1 year ago

Description

PCSX2 has dropped the support for anything but appimages. The profile needs to be adjusted. Also, when you try building it yourself (explicitely unsupported by upstream), there are two flavors: the deprecated GTK PCSX2 binary and the qt (iirc called PCSX2-qt, capitalization might be off) one, adding extra complexity that might need to be taken care of for users of older PCSX2 builds (debian? ubuntu?). The comments on this, which was dropped from the community, might help, too: https://aur.archlinux.org/packages/pcsx2

If possible, assign a Help Wanted label to this issue. In any case, I think some input on how to handle the situation with both appimages and binaries is appreciated as it is not really clear how to proceed.

glitsj16 commented 1 year ago

Did you test the current PCSX2.profile with an AppImage yet? A quick glance at the profile suggests these potential bottlenecks:

Obviously firecfg wouldn't be able to create a working symlink for an AppImage. A simple shell wrapper like the below should work without any changes to the current profile - assuming both the script and the AppImage are placed in /usr/local/bin:

#!/bin/sh
# firejail wrapper for PCSX2 AppImage
firejail --appimage --profile=PCSX2 /usr/local/bin/PCSX2.AppImage
NetSysFire commented 1 year ago

Did you test the current PCSX2.profile with an AppImage yet?

No, not yet.

users who place the AppImage under their home dir

I am unsure but I think upstreams proposed workflow is that no distros should package PCSX2 and instead want users download the appimages manually. Which means it will usually be in $DOWNLOADS. The file name I just fetched from their website would be pcsx2-v1.7.4245-linux-AppImage-64bit-Qt.AppImage. It is dynamic, so it will likely cause issues, too I guess.

rusty-snake commented 1 year ago

@glitsj16 Noexec works fine with AIs as long as you use --appimage.