Cannot whitelist ${RUNUSER}/gnupg

OneOfOne commented 1 year ago

Description

I can't whitelist ${RUNUSER}/gnupg.

Steps to Reproduce

include whitelist-run-common.inc
include whitelist-runuser-common.inc

whitelist ${HOME}/.gnupg
noblacklist ${RUNUSER}/gnupg
whitelist ${RUNUSER}/gnupg

Steps to reproduce the behavior

LC_ALL=C firejail --profile=bug --whitelist=/run/user/1000/gnupg ls -lah /run/user/1000/gnupg
ls: cannot open directory '/run/user/1000/gnupg': Permission denied

Expected behavior

to be able to see the contents of the dir.

Actual behavior

What actually happened

Behavior without a profile

_What changed calling LC_ALL=C firejail --noprofile /path/to/program in a terminal?_

Nothing, still shows permission denied.

Environment

Arch Linux

firejail version 0.9.72

Compile time support:
        - always force nonewprivs support is disabled
        - AppArmor support is enabled
        - AppImage support is enabled
        - chroot support is enabled
        - D-BUS proxy support is enabled
        - file transfer support is enabled
        - firetunnel support is disabled
        - IDS support is disabled
        - networking support is enabled
        - output logging is enabled
        - overlayfs support is disabled
        - private-home support is enabled
        - private-cache and tmpfs as user enabled
        - SELinux support is disabled
        - user namespace support is enabled
        - X11 sandboxing support is enabled

Checklist

[x] The issues is caused by firejail (i.e. running the program by path (e.g. /usr/bin/vlc) "fixes" it).
[x] I can reproduce the issue without custom modifications (e.g. globals.local).
[ ] The program has a profile. (If not, request one in https://github.com/netblue30/firejail/issues/1139)
[ ] The profile (and redirect profile if exists) hasn't already been fixed upstream.
[x] I have performed a short search for similar issues (to avoid opening a duplicate).
- [x] I'm aware of browser-allow-drm yes/browser-disable-u2f no in firejail.config to allow DRM/U2F in browsers.
[ ] I used --profile=PROFILENAME to set the right profile. (Only relevant for AppImages)

Log

Output of LC_ALL=C firejail /path/to/program

```console $ LC_ALL=C firejail --noprofile --whitelist=/run/user/1000/gnupg ls -lah /run/user/1000/ Parent pid 576980, child pid 576981 Warning: not remounting /var/lib/docker/btrfs Warning: not remounting /var/lib/docker/btrfs Warning: not remounting /var/lib/docker/btrfs Child process initialized in 5.20 ms total 0 drwx------ 3 oneofone oneofone 60 Oct 9 18:54 . drwxr-xr-x 3 root root 60 Oct 9 18:54 .. dr-------- 2 root root 40 Oct 7 06:18 gnupg ```

Output of LC_ALL=C firejail --debug /path/to/program

```console $ LC_ALL=C firejail --noprofile --whitelist=/run/user/1000/gnupg --debug ls -lah /run/user/1000/ Building quoted command line: 'ls' '-lah' '/run/user/1000/' Command name #ls# DISPLAY=:1 parsed as 1 Using the local network stack Parent pid 577084, child pid 577088 Initializing child process Host network configured PID namespace installed Mounting tmpfs on /run/firejail/mnt directory Creating empty /run/firejail/mnt/seccomp directory Creating empty /run/firejail/mnt/seccomp/seccomp.protocol file Creating empty /run/firejail/mnt/seccomp/seccomp.postexec file Creating empty /run/firejail/mnt/seccomp/seccomp.postexec32 file IBUS_ADDRESS=unix:path=/home/oneofone/.cache/ibus/dbus-uUe3KAvA,guid=918f9cab65ee8818bb39fa2e64f7b8e4 IBUS_DAEMON_PID=15659 Mounting /proc filesystem representing the PID namespace Basic read-only filesystem: Mounting read-only /etc 891 656 0:30 /@/etc /etc ro,noatime master:1 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=372,subvol=/@ mountid=891 fsname=/@/etc dir=/etc fstype=btrfs Mounting noexec /etc 892 891 0:30 /@/etc /etc ro,nosuid,nodev,noexec,noatime master:1 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=372,subvol=/@ mountid=892 fsname=/@/etc dir=/etc fstype=btrfs Mounting read-only /var 897 893 0:30 /@varlog /var/log rw,noatime master:62 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=375,subvol=/@varlog mountid=897 fsname=/@varlog dir=/var/log fstype=btrfs Mounting read-only /var/lib/docker 954 898 0:30 /@varlibdocker/btrfs /var/lib/docker/btrfs rw,noatime master:56 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=376,subvol=/@varlibdocker mountid=954 fsname=/@varlibdocker/btrfs dir=/var/lib/docker/btrfs fstype=btrfs Warning: not remounting /var/lib/docker/btrfs Mounting read-only /var/tmp 955 896 0:46 / /var/tmp ro,nosuid,nodev,relatime master:58 - tmpfs tmpfs rw,inode64 mountid=955 fsname=/ dir=/var/tmp fstype=tmpfs Mounting read-only /var/log 956 897 0:30 /@varlog /var/log ro,noatime master:62 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=375,subvol=/@varlog mountid=956 fsname=/@varlog dir=/var/log fstype=btrfs Mounting noexec /var 986 985 0:30 /@varlog /var/log ro,noatime master:62 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=375,subvol=/@varlog mountid=986 fsname=/@varlog dir=/var/log fstype=btrfs Mounting noexec /var/lib/docker 988 987 0:30 /@varlibdocker/btrfs /var/lib/docker/btrfs rw,noatime master:56 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=376,subvol=/@varlibdocker mountid=988 fsname=/@varlibdocker/btrfs dir=/var/lib/docker/btrfs fstype=btrfs Warning: not remounting /var/lib/docker/btrfs Mounting noexec /var/tmp 989 967 0:46 / /var/tmp ro,nosuid,nodev,noexec,relatime master:58 - tmpfs tmpfs rw,inode64 mountid=989 fsname=/ dir=/var/tmp fstype=tmpfs Mounting noexec /var/log 990 986 0:30 /@varlog /var/log ro,nosuid,nodev,noexec,noatime master:62 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=375,subvol=/@varlog mountid=990 fsname=/@varlog dir=/var/log fstype=btrfs Warning: not remounting /var/lib/docker/btrfs Mounting read-only /usr 991 656 0:30 /@/usr /usr ro,noatime master:1 - btrfs /dev/nvme0n1p3 rw,compress=zstd:3,ssd,discard=async,space_cache=v2,subvolid=372,subvol=/@ mountid=991 fsname=/@/usr dir=/usr fstype=btrfs Mounting tmpfs on /var/lock Mounting tmpfs on /var/tmp Mounting tmpfs on /var/log Mounting tmpfs on /var/cache/lighttpd Create the new utmp file Mount the new utmp file Cleaning /home directory Cleaning /run/user directory Sanitizing /etc/passwd, UID_MIN 1000 Sanitizing /etc/group, GID_MIN 1000 Disable /home/oneofone/.dotfiles/.config/firejail (requested /home/oneofone/.config/firejail) Disable /run/firejail/sandbox Disable /run/firejail/network Disable /run/firejail/bandwidth Disable /run/firejail/name Disable /run/firejail/profile Disable /run/firejail/x11 blacklist /run/firejail/dbus Mounting read-only /proc/sys Remounting /sys directory Disable /sys/firmware Disable /sys/hypervisor Disable /sys/power Disable /sys/kernel/debug Disable /sys/kernel/vmcoreinfo Disable /proc/sys/fs/binfmt_misc Disable /proc/sys/kernel/core_pattern Disable /proc/sys/kernel/modprobe Disable /proc/sysrq-trigger Disable /proc/sys/vm/panic_on_oom Disable /proc/irq Disable /proc/bus Disable /proc/timer_list Disable /proc/kcore Disable /proc/kallsyms Disable /usr/lib/modules/6.5.6-arch2-1/build (requested /usr/src/linux) Disable /usr/lib/modules (requested /lib/modules) Disable /boot Disable /dev/port Disable /run/user/1000/gnupg Disable /run/user/1000/systemd Disable /dev/kmsg Disable /proc/kmsg Debug 588: whitelist /run/user/1000/gnupg Debug 609: expanded: /run/user/1000/gnupg Debug 620: new_name: /run/user/1000/gnupg Debug 630: dir: /run/user/1000 Adding whitelist top level directory /run/user/1000 Mounting tmpfs on /run/user/1000, check owner: no 1030 1001 0:113 / /run/user/1000 rw,nosuid,nodev,relatime - tmpfs tmpfs rw,mode=700,uid=1000,gid=1000,inode64 mountid=1030 fsname=/ dir=/run/user/1000 fstype=tmpfs Whitelisting /run/user/1000/gnupg 1031 1030 0:24 /firejail/firejail.ro.dir /run/user/1000/gnupg ro,nosuid,nodev master:12 - tmpfs tmpfs rw,size=13114372k,nr_inodes=819200,mode=755,inode64 mountid=1031 fsname=/firejail/firejail.ro.dir dir=/run/user/1000/gnupg fstype=tmpfs Disable /sys/fs Disable /sys/module Current directory: /tmp/x DISPLAY=:1 parsed as 1 Masking all X11 sockets except /tmp/.X11-unix/X1 Mounting read-only /run/firejail/mnt/seccomp 1036 888 0:105 /seccomp /run/firejail/mnt/seccomp ro,nosuid - tmpfs tmpfs rw,mode=755,inode64 mountid=1036 fsname=/seccomp dir=/run/firejail/mnt/seccomp fstype=tmpfs Seccomp directory: ls /run/firejail/mnt/seccomp drwxr-xr-x root root 120 . drwxr-xr-x root root 160 .. -rw-r--r-- oneofone oneofone 640 seccomp -rw-r--r-- oneofone oneofone 432 seccomp.32 -rw-r--r-- oneofone oneofone 0 seccomp.postexec -rw-r--r-- oneofone oneofone 0 seccomp.postexec32 No active seccomp files Drop privileges: pid 1, uid 1000, gid 1000, force_nogroups 0 Closing non-standard file descriptors Starting application LD_PRELOAD=(null) execvp argument 0: ls execvp argument 1: -lah execvp argument 2: /run/user/1000/ Child process initialized in 7.03 ms Searching $PATH for ls trying #/usr/local/sbin/ls# trying #/usr/local/bin/ls# trying #/usr/bin/ls# total 0 drwx------ 3 oneofone oneofone 60 Oct 9 18:54 . drwxr-xr-x 3 root root 60 Oct 9 18:54 .. dr-------- 2 root root 40 Oct 7 06:18 gnupg monitoring pid 2 Sandbox monitor: waitpid 2 retval 2 status 0 ```

glitsj16 commented 1 year ago

noblacklist ${RUNUSER}/gnupg

That would only make sense if there was a blacklist ${RUNUSER}/gnupg, which there isn't.

${RUNUSER}/gnupg (and ${RUNUSER}/systemd) are considered special paths by Firejail. A feature (introduced in 0.9.46):

https://github.com/netblue30/firejail/blob/84ade11cbe6885932356ed20982e1b4c940d314c/RELNOTES#L662

You need writable-run-user:

https://github.com/netblue30/firejail/blob/84ade11cbe6885932356ed20982e1b4c940d314c/src/man/firejail.1.in#L3116-L3117

OneOfOne commented 1 year ago

Thank you, that worked.

netblue30 / firejail