netbookai / spawner

Mulit-Cloud infrastructure orchestrator for kubernetes first development.

https://netbook-2.gitbook.io/netbook-docs/opensource/docs/spawner

GNU General Public License v3.0

56 stars 10 forks source link

delete snapshot after restoring into new volume #20

Closed NishanthSpShetty closed 2 years ago

NishanthSpShetty commented 2 years ago

Description

Delete snapshot after restoring the snapshot state to new volume if the deleteSnapshot is set

Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

why

When we restore snapshot into new volume, we leave snapshot as it, which accumulates over the period and becomes harder to cleanup.

How Has This Been Tested?

manually create volume from snapshot and spawner deletes the snapshot

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication