netbookai / spawner

Mulit-Cloud infrastructure orchestrator for kubernetes first development.

https://netbook-2.gitbook.io/netbook-docs/opensource/docs/spawner

GNU General Public License v3.0

56 stars 10 forks source link

refactor labels, namespace all labels created by spawner with 'netbook.ai' #33

Closed NishanthSpShetty closed 2 years ago

NishanthSpShetty commented 2 years ago

Description

Add tags to resources created by spawner by namespacing it under netbook.ai/. Refactor label constants.

This change requires to change existing resources with updated tag key with the namespace/(prefix), spawner will fail to recognise the resources already created prior this change.

following resources/tags must be changed to new format,

scope changed to netbook.ai/scope
all tags in vpc, subnet must have all of its tags prefixed netbook.ai/XXX except tag Name.

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

why

enable user to setup the tags they need without conflicting with spawner labels.

How Has This Been Tested?

Manually tested.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
13.2% Duplication

sid255 commented 2 years ago

Let's not merge it just yet.