imaskm commented 2 years ago

Description

cost from clouds is returned in float/string format, in spawner now we are using Decimal type for all operations, the cost rpcs will return the cost 1/100th of cents as integer

Fixes # (issue) avoid using float as cost type

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update

why

How Has This Been Tested?

using "testclient", ran the cost rpc calls for different workspaces

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

NishanthSpShetty commented 2 years ago

can we wrap errors instead of returning err directoctly with some message or function name, like

return errors.Wrap(err, "GetApplicationCost")

or with more description as return errors.Wrap(err, "GetApplicationCost: unable to get the value")

imaskm commented 2 years ago

can we wrap errors instead of returning err directoctly with some message or function name, like

return errors.Wrap(err, "GetApplicationCost")

or with more description as return errors.Wrap(err, "GetApplicationCost: unable to get the value")

Done