netbookai / spawner

Mulit-Cloud infrastructure orchestrator for kubernetes first development.

https://netbook-2.gitbook.io/netbook-docs/opensource/docs/spawner

GNU General Public License v3.0

56 stars 10 forks source link

refactor return interface and unexported struct #45

Closed NishanthSpShetty closed 2 years ago

NishanthSpShetty commented 2 years ago

Description

export interfaces not struct, make controller struct private and export the interface.

Type of change

[x] refactor/improvemtns.
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication