netbookai / spawner

Mulit-Cloud infrastructure orchestrator for kubernetes first development.

https://netbook-2.gitbook.io/netbook-docs/opensource/docs/spawner

GNU General Public License v3.0

56 stars 10 forks source link

fix CreateRoute53Records to upsert, unquote route53 record values in GetRoute53TXTRecords #60

Closed sid255 closed 2 years ago

sid255 commented 2 years ago

Description

fixing CreateRoute53Records to use upsert instead of create
to maintain uniformity unquoting record values in GetRoute53TXTRecords, in CreateRoute53Records we are expecting plain strings and quoting them before passing to AWS

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

why

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

imaskm commented 2 years ago

LGTM