netbootxyz / docker-netbootxyz

netboot.xyz docker container
https://netboot.xyz/docs/docker
162 stars 50 forks source link

Make port 80 configurable in nginx. #53

Closed CompPhy closed 7 months ago

CompPhy commented 7 months ago

Is there a specific reason why port 80 is the default for nginx here? This is a blocker for host network binding because it could conflict with a lot of other services on the host.

Your own deployment document suggests port 8080 as the access port, so why not use this as the default in nginx? Even if you do keep port 80 as the default, can it at least get an override through environment variable?