netbootxyz / netboot.xyz

Your favorite operating systems in one place. A network-based bootable operating system installer based on iPXE.
https://netboot.xyz
Apache License 2.0
8.78k stars 663 forks source link

Incorrect behavior since PR#1365 was merged #1381

Closed gmarcy closed 8 months ago

gmarcy commented 8 months ago

Describe the bug

Ever since PR#1365 was merged my systems all boot into the interactive menu instead of using the boot filename returned from DHCP server. images were built w/ explicit

bootloader_tftp_enabled: false

To Reproduce Steps to reproduce the behavior:

  1. reboot a system using ipxe when dhcp returns a filename to use to boot. tftp-server is set to next-server here:
    isset ${next-server} && isset ${proxydhcp/next-server} && goto choose-tftp || set tftp-server ${next-server} && goto load-custom-ipxe
  2. since filename is set you always end up in tftpmenu
    :load-custom-ipxe
    isset ${tftp-server} && isset ${filename} && goto tftpmenu
  3. tftpmenu never even uses filename, so will always end up here
    chain --autofree tftp://${tftp-server}/menu.ipxe

Expected behavior

I expect it to use the filename I've configured dhcp to return and I expect it to use http on the server I've configured in the boot_domain rather then booting from the tftp server when I've disabled booting from tftp

Screenshots

Additional context