search

netbootxyz / webapp

NodeJS helper Application for managing local deployments of netboot.xyz
https://netboot.xyz/docs/docker
Apache License 2.0
57 stars 13 forks source link

Full Support For Environment Proxy (http, https, no_proxy) #73

Open Mionsz opened 3 months ago

Mionsz commented 3 months ago

Full http_proxy https_proxy, no_proxy suupport:

Support for http_proxy, https_proxyh and no_proxy environment variables implemented. This include reading variables from process environment, comparing request_url with no_proxy cidr's and names, and of course setting and redirecting requests using proxy or corporate proxy services. This does not impact by any means the DHCP and TFTP services - only webapp.

Environments read for comparision:

Implemented and/or extended:

One method for each approach getProxyAgentFromUrl(). Almost no changes to the code are needed.

This fully resolves: https://github.com/netbootxyz/webapp/issues/66

Fiooodooor commented 2 months ago

@antonym @vangorra @thelamer ping. The PR adds support for proxy servers as well as adds changes from docker-netbootxyz that are not reflected here.

Mionsz commented 1 month ago

Another ping - would be grateful for a review - @antonym @vangorra @thelamer ping

Mionsz commented 1 month ago

I've changed it as you mentioned. IF you find some time I would be grateful for a review :). We can then move along and I will introduce a ready Kubernetes / Harvester set of YAML files or we can create Helm chart for this as most of folks probably would love to have it ready to be deployed. I am currently running NetBoot.xyz on a secure harvester cluster behind a corporate proxy and still being able to boot OS from it on most of our subnets after some tuning.

BTW the project if really awesome!

Fiooodooor commented 3 weeks ago

@antonym @vangorra @thelamer ping and review request. @cp-whatcha could you check if this works for you?