search

netbox-community / Device-Type-Library-Import

This library is intended to assist with importing device and module types into NetBox from the NetBox Community DeviceType-Library
https://github.com/netbox-community/devicetype-library
MIT License
256 stars 77 forks source link

docker build + add vendors choices as env var #23

Closed k0rventen closed 3 years ago

k0rventen commented 3 years ago

Hi,

This PR adds a Dockerfile making possible to run the project as a container. It also enables the selection of vendors through an VENDORS env var, with the same behavior as the --vendors arg, so that everything is configurable through env var.

Regarding the documentation, I think a new section could be added, but I wanted to check if you were ok with the feature beforehand.

thx!

ndom91 commented 3 years ago

Looks good to me! I'm sure @minitriga will approve as well. This is great for people who (gasp! haha) may not have a local installation of python.

k0rventen commented 3 years ago

Thx @ndom91 ! I've added the docker specific documentation.

Would it be possible to also host this image on a container registry ? I'm willing to setup the CI required.

minitriga commented 3 years ago

If you want to setup the CI required with Github actions then we can get something hosted yes.

minitriga commented 3 years ago

Sorry $dayjob has me very busy working on other things right now so I try to look when i can. Thanks for all the good work @k0rventen and @ndom91