netbox-community / Device-Type-Library-Import

This library is intended to assist with importing device and module types into NetBox from the NetBox Community DeviceType-Library
https://github.com/netbox-community/devicetype-library
MIT License
256 stars 77 forks source link

Part Number/DeviceType Update #27

Closed typecookie closed 1 year ago

typecookie commented 3 years ago

There where several Ubiquiti devises with the device type and part number backwards on the device type library, This has been fixed but running the Import script dose not recognize this. 2021-07-02 09_20_39-Ubiquiti by typecookie · Pull Request #422 · netbox-community_devicetype-library

ndom91 commented 3 years ago

So the script will search for device types based on the model, meaning if the device type library has updated the model numbers of these Ubiquiti devices, this script should not find an existing entry in the DB under the new model and go on creating it. It won't update the existing one.

Can you check if there are not new Ubiquiti device types in your Netbox?

See L271 for the db get logic for deviceTypes: https://github.com/minitriga/Netbox-Device-Type-Library-Import/blob/e8ac3e779c5b42a7a5832a58c8c1644dc6fe8cad/nb-dt-import.py#L268-L327

danner26 commented 1 year ago

Hello @typecookie, this is an expected behavior just as @ndom91 described.

As a heads up, the NetBox Community will be taking over this repository. Due to the fact that this issue has been around for a very long time and we have updated the requirements within this repository as well as the new codebase for NetBox and DeviceType-Library, I am going to close it. Should you encounter any further issues, please feel free to contact us. Thank you!