search

netbox-community / Device-Type-Library-Import

This library is intended to assist with importing device and module types into NetBox from the NetBox Community DeviceType-Library
https://github.com/netbox-community/devicetype-library
MIT License
256 stars 77 forks source link

fix: error on unambigious powerport when trying to create power outlets #4

Closed ndom91 closed 3 years ago

ndom91 commented 3 years ago

There is an APC template in the device-type library that would always cause this to fail. The APC AP7721.

Problem is there are two power ports, and the template's power outlets are not assigned to either of them. So the .get() on https://github.com/minitriga/Netbox-Device-Type-Library-Import/blob/master/nb-dt-import.py#L181 would error because it returned two results instead of one unambiguous one.

I currently just wrapped it in a try/except where it spits out an error that it couldn't add that power outlet because its not sure which power port to assign it to.

I noticed in the Netbox UI, however, that power port is not a required field for power outlets. So I want to see if I can get this to work to add the power outlet without assigning a port, therefore the current WIP status.

ndom91 commented 3 years ago

Okay, second commit basically just creates the outlet anyway without linking a powerport when more than one is returned and the template doesn't specify.

I'm sure theres a more concise way of doing this though, I'm no python expert.