netbox-community / Device-Type-Library-Import

This library is intended to assist with importing device and module types into NetBox from the NetBox Community DeviceType-Library
https://github.com/netbox-community/devicetype-library
MIT License
248 stars 75 forks source link

Module bays and types import #51

Closed dmcken closed 1 year ago

dmcken commented 1 year ago

Just checking whats the status of this?

I'm seeing modules in the devicetype-library but this tool isn't importing them.

I don't mind working on it or contributing to this if no one else is working on it.

dmcken commented 1 year ago

Just want to know if I should take up the task or if someone else is already working on it.

arcticash commented 1 year ago

I was just looking for a solution to this exact problem, I've run a full import successfully yet none of the Device Types have module bays, and none of the Module Types are created.

Looks like this repo hasn't been updated in 8+ months so not sure if this plugin is just really stable or the project has been abandoned :(

ndom91 commented 1 year ago

Are "module bays" and "module types" new models in Netbox? If so, this importer will have to be updated. Otherwise, its up to the folks maintaining the entries in the Netbox Device Type library to add accurate info

arcticash commented 1 year ago

Are "module bays" and "module types" new models in Netbox? If so, this importer will have to be updated. Otherwise, its up to the folks maintaining the entries in the Netbox Device Type library to add accurate info

Not sure, it's noted in the device type library repo that they are supported as of v3.2, not really sure how to use the definition's without the importer though!

I've been checking through the device type library and it does look like the info is in there, presumably just not interpreted by the importer yet

ndom91 commented 1 year ago

@arcticash yeah so it looks like moduletypes were added as of 3.2.0 (See: https://github.com/netbox-community/netbox/releases/tag/v3.2.0).

There have also been a good amt of netbox REST API updates in the latest few releases it looks like.

That means this importer library could definitely use a bit of a clean-up to bring it back up-to-date with the latest Netbox releases.

If anyone has the time and/or motivation to open a PR, I'm sure @minitriga would be very grateful 😁

dmcken commented 1 year ago

Pull request available at: https://github.com/minitriga/Netbox-Device-Type-Library-Import/pull/52

minitriga commented 1 year ago

Thank you @dmcken