IGNORE_SSL_ERRORS not propigating

netbox-community / Device-Type-Library-Import

This library is intended to assist with importing device and module types into NetBox from the NetBox Community DeviceType-Library

https://github.com/netbox-community/devicetype-library

MIT License

270 stars 89 forks source link

IGNORE_SSL_ERRORS not propigating #95

Closed skyefugate closed 1 year ago

skyefugate commented 1 year ago

Hi -- I tried running the importer on my instance of Netbox and I ran into issues where when I set the IGNORE_SSL_ERRORS to 'True' it was not propagating all the way. The resolution to this was to set line 481 in netbox_api.py to the below.

response = requests.patch(url, headers=headers, files=files, verify=False)

What was added was ', verify=False'

This just needs to take the propagation from the .env file to fix. Thanks!

danner26 commented 1 year ago

Thank you for this. This also assisted us in catching an issue with permissions that we did not know about previously.

danner26 commented 1 year ago

This issue is now resolved in Release v2.0.1