search

netbox-community / devicetype-library

A collection of community-sourced DeviceType definitions for import to NetBox
Creative Commons Zero v1.0 Universal
884 stars 876 forks source link

Audit Panduit definitions for incorrect child devices #1129

Closed jeremystretch closed 1 year ago

jeremystretch commented 1 year ago

Seems that a few Panduit device types should actually be modules. For example: https://github.com/netbox-community/devicetype-library/blob/master/device-types/Panduit/FAP12WAGDLCZ.yaml

Nealtron commented 1 year ago

I did a little bit of leg work on this since this directly benefits me, but I have no GIT experience so unfortunately I have 2 separate changes in a single PR https://github.com/netbox-community/devicetype-library/pull/1188

Nealtron commented 1 year ago

@jeremystretch, my PR was merged. Do you see any more modules that might have been missed?

DanSheps commented 1 year ago

Conversely, I actually model these as child devices as I prefer the way they show on a device trace.

I do think that some of those definitions are incorrect as there are acutally 2 MPO12 connectors and 24 LC strands (each strand has a A and a B side)