netbox-community / devicetype-library

A collection of community-sourced DeviceType definitions for import to NetBox
Creative Commons Zero v1.0 Universal
884 stars 876 forks source link

duplicate model name in device-types/Cisco/WS-C3750G-12S-S.yaml and WS-C3750G-12S-E.yaml #1171

Closed alextremblay closed 1 year ago

alextremblay commented 1 year ago

https://github.com/netbox-community/devicetype-library/blob/bd9fce16f25f0601707dd31faf9430534ddd5da3/device-types/Cisco/WS-C3750G-12S-S.yaml#L3 https://github.com/netbox-community/devicetype-library/blob/bd9fce16f25f0601707dd31faf9430534ddd5da3/device-types/Cisco/WS-C3750G-12S-E.yaml#L3

Both use the same model name as WS-C3750G-12S.yaml

danner26 commented 1 year ago

Hello @alextremblay, great catch. Do you want to create a PR to fix this?

Nealtron commented 1 year ago

Looks like the only difference between those 2 models is the version of firmware they are running. So wouldn't the best option be the removal of duplicate devices?

https://community.cisco.com/t5/switching/ws-c3750g-12s-e-and-ws-c3750g-12s-s-v04/td-p/2586654