netbox-community / go-netbox

The official Go API client for Netbox IPAM and DCIM service.
Other
195 stars 146 forks source link

Create a new tag #57

Closed smutel closed 4 years ago

smutel commented 4 years ago

Hello,

Could you please create a new tag for this library ? I am using Gopkg.toml and dep command and it seems that I can only lock version with tags, not master.

Thanks.

kobayashi commented 4 years ago

What kind of tags you need?

smutel commented 4 years ago

I need a git tag on this repository ...

In my Gopkg.toml, I have this:

[[constraint]]                                                                  
  name = "github.com/netbox-community/go-netbox"                                
  version = "netbox_v2.4"

But the netbox_v2.4 tag is not good for me. I need a more recent tag to use in my code.

kobayashi commented 4 years ago

I just have set tag netbox_v2.6 from the current master.

smutel commented 4 years ago

Hello,

Thank you for the tag. Previously I used this piece of code but it seems that the function NewNetboxWithAPIKey does not exist anymore:

import (                
  netboxapi "github.com/netbox-community/go-netbox/netbox"                      
)

func configureProvider(d *schema.ResourceData) (interface{}, error) {           
  url := d.Get("url").(string)                                                  
  token := d.Get("token").(string)                                              

  return netboxapi.NewNetboxWithAPIKey(url, token), nil                         
}

Could you please help me to convert this code with the netbox_2.6 tag ?

kobayashi commented 4 years ago

Added new tag netbox_2.7 which include netbox package. Plz check it. Thanks!

smutel commented 4 years ago

Is this tag compatible with Netbox 2.6 ?