Feature/upstream id field fixes

netbox-community / go-netbox

The official Go API client for Netbox IPAM and DCIM service.

Other

194 stars 144 forks source link

Feature/upstream id field fixes #98

Closed hensoko closed 2 years ago

hensoko commented 3 years ago

There are several fields in swagger.json which have the wrong type assigned (string vs integer / number). This is mainly found with "id" and "*_id" fields. This PR should fix that.

See also #93

hensoko commented 3 years ago

Hey @Boulet- @awlx,

it seems that recreating the pull-request does not really help. Any idea how to proceed now? Maybe we can try in smaller chunks? Each commit can be applied independently.

awlx commented 3 years ago

Did you test the code you submitted? I can't really explain what is happeing if it works as submitted.

hensoko commented 3 years ago

@awlx Yeah I tested it and am using it daily and checked the commits several times

awlx commented 3 years ago

Ok, so I waiting for a confirm of #100 that this fixes this problem too. And will test it once more on my machine. If this all confirms we merge it.

Is that ok for you?

hensoko commented 3 years ago

Yeah sure :+1:

hensoko commented 3 years ago

Hey, any news on this? #98 seems not to be related so I wonder if the PR can be merged now?