search

netbox-community / netbox-chart

A Helm chart for NetBox
https://netbox.readthedocs.io/
Apache License 2.0
247 stars 149 forks source link

Main branch is not default #175

Open zakkg3 opened 7 months ago

zakkg3 commented 7 months ago

dismiss this and read the next comment.

Values files specify the need for keys on the existingSecret, but "napalm_password" is not there and the pod does not start if this is missing.

  Warning  FailedMount             85s (x2 over 3m27s)   kubelet                  MountVolume.SetUp failed for volume "secrets" : references non-existent secret key: napalm_password
zakkg3 commented 7 months ago

I found the problem is that the default branch here is not main and you land by default on dev branch so the 5.0.0 chart which is not published.

The latest we can use is 4.1.1 and this is on main branch, wich is not the main one. o,0

very confusing, And I am pretty sure I am not the first one misled by this.

I guess the most sane would be to set main as the default branch and all this will be solved, like in every single reasonable repo

tpzumezawa commented 7 months ago

Happened to us :(

bootc commented 7 months ago

Yeah I could do that, but it's a double-edged sword. People contributing PRs would target the wrong branch and end up with wasted work/time fixing things that are already fixed, or having to redo their changes because what they're targeting has changed. GitHub unfortunately makes this very difficult.

LeoColomb commented 3 months ago

Based on the new release workflow, I think it is fine to drop the master branch and rename develop to main. The complete history is still part of the main branch, and the tags keep the stable git HEAD available. What do you think @netbox-community/netbox-chart-maintainers?

RangerRick commented 3 months ago

Based on the new release workflow, I think it is fine to drop the master branch and rename develop to main. The complete history is still part of the main branch, and the tags keep the stable git HEAD available. What do you think @netbox-community/netbox-chart-maintainers?

Yeah, makes sense to just use once since we've got a just-in-time thing going now. That said, maybe it makes sense to merge develop over to main, and get rid of develop? It would signal better how the current workflow is, IMHO.

LeoColomb commented 3 months ago

I believe that is the same, with a merge step in addition 😅 (there is no main at the moment)

RangerRick commented 3 months ago

Oops I meant master in this case, not main.

RangerRick commented 1 month ago

Since we've moved to a more dynamic workflow in general (single branch for release -- currently develop -- and then everything comes from PRs) I will fix this when 5.0.0 rolls out for real.