Add a schema for values validation

netbox-community / netbox-chart

A Helm chart for NetBox

https://netbox.readthedocs.io/

Apache License 2.0

261 stars 153 forks source link

Closed LeoColomb closed 4 weeks ago

LeoColomb commented 2 months ago

This PR adds the values.schema.json file. It is the standard schema file for values validation.

The proposed version is relatively naive, auto-generated and without further customization.

LeoColomb commented 2 months ago

Upgrade check failure is directly linked to the type change: the validation of values before upgrades is failing. https://github.com/netbox-community/netbox-chart/actions/runs/10782731200/job/29903300695?pr=334#step:7:107

In theory, this should request a major version bump.

RangerRick commented 2 months ago

Love having a schema at least, been wanting to do that.

LeoColomb commented 2 months ago

@RangerRick Happy to help 😁 Just so it's clear, the upgrade check will always fail because of the type change without major version bump.

RangerRick commented 2 months ago

Yeah, well, I was planning on merging it anyway, but i guess our permissions lockdown means I can't, lol. I'll look at it tomorrow.