search

netbox-community / netbox-chart

A Helm chart for NetBox
https://netbox.readthedocs.io/
Apache License 2.0
261 stars 153 forks source link

Minor updates README #368

Closed D1StrX closed 1 month ago

D1StrX commented 1 month ago

Perhaps some values should be merged/removed to cleanup the values.yaml. For example the global.storageClass, persistence.storageClass, reportsPersistence.storageClass and scriptsPersistence.storageClass. Use individual defined storageclasses else global.storageClass or use user defined PVC. Leaves the cluster default storageclass to be sorted.

This part isn't used by Netbox, only the Bitnami Charts if even relevant.

## @param kubeVersion Override Kubernetes version
##
kubeVersion: ""
LeoColomb commented 1 month ago

For example the global.storageClass, persistence.storageClass, reportsPersistence.storageClass and scriptsPersistence.storageClass. Use individual defined storageclasses else global.storageClass or use user defined PVC.

Indeed, this should be done using common.storage.class helper. Is about to be added/fixed via #364.

This part isn't used by Netbox, only the Bitnami Charts if even relevant.

You're right, kubeVersion is probably safe to remove.