search

netbox-community / netbox-chart

A Helm chart for NetBox
https://netbox.readthedocs.io/
Apache License 2.0
261 stars 153 forks source link

Tweak YAML rendering using common render helpers #405

Open LeoColomb opened 2 weeks ago

LeoColomb commented 2 weeks ago

Tweak YAML rendering using common render helpers, and resolves https://github.com/netbox-community/netbox-chart/issues/403. Helps to reduce mistake surface in the rendering.

Also add extraEnvVarsCM and extraEnvVarsSecret as shortcuts to gather vars from CM or Secret directly.

NeodymiumFerBore commented 2 weeks ago

Thank you for implementing this so quickly! Docstrings don't say that extraEnvVarsCM and extraEnvVarsSecret can be templated strings. Is it intentional?

LeoColomb commented 2 weeks ago

@NeodymiumFerBore Not intentional, but the current state of docstring is far from perfection anyway. I have a refresh in my to-do list, but keeping everything aligned and in sync with is a real pain.