search

netbox-community / netbox-docker

🐳 Docker Image of NetBox
https://github.com/netbox-community/netbox-docker/wiki
Apache License 2.0
1.81k stars 828 forks source link

Redis sentinel #1130

Closed tagur87 closed 8 months ago

tagur87 commented 9 months ago

Related Issue:

New Behavior

Add Redis Sentinel Support to the netbox-docker image. Allowing setting of the values defined here: https://demo.netbox.dev/static/docs/configuration/required-settings/#using-redis-sentinel

Contrast to Current Behavior

Can only set normal redis settings in current image.

Discussion: Benefits and Drawbacks

Redis sentinel is the high availability redis reccomended by netbox in the docs, and is supported. The container should support it too.

Changes to the Wiki

Maybe updating docs with values supported?

Proposed Release Note Entry

Double Check

tagur87 commented 9 months ago

Thanks for fixing that @tobiasge - I am double checking what I submitted works as expected. I will put as draft for now.

tagur87 commented 9 months ago

Having an issue getting the SENTINELS variable to work as expected, since it's tuples in an array...

tobiasge commented 8 months ago

Addressed in #1134