Add xmlsec with no-binary option

netbox-community / netbox-docker

🐳 Docker Image of NetBox

https://github.com/netbox-community/netbox-docker/wiki

Apache License 2.0

1.81k stars 828 forks source link

Add xmlsec with no-binary option #1230

Closed lchastel closed 4 months ago

lchastel commented 4 months ago

SAML backend is still not working. I have the issue "lxml & xmlsec libxml2 library version mismatch".

Related Issue:

New Behavior

Adding xmlsec to requirements-container.txt for python3-saml like it's done for lxml solve the issue.

Contrast to Current Behavior

When enabling SAML backend, I receives the error message lxml & xmlsec libxml2 library version mismatch

How to reproduce ?

Follow Quickstart of netbox-docker
Add next lines to env/netbox.env REMOTE_AUTH_BACKEND='social_core.backends.saml.SAMLAuth' DEBUG=true
Start or restart netbox docker compose up -d
Connect to the netbox instance (you may have to click on login) Here is the result ...

Discussion: Benefits and Drawbacks

...

Changes to the Wiki

...

Proposed Release Note Entry

...

Double Check

[X] I have read the comments and followed the PR template.
[X] I have explained my PR according to the information in the comments.
[X] My PR targets the develop branch.

cimnine commented 4 months ago

Thanks for the PR. This looks fine to me, what do you think @tobiasge ? @lchastel could you update your PR with the latest changes from the develop branch?

jonlarsdizparc commented 3 months ago

@cimnine Should this fix be automatically updated into new docker hub builds? I'm still experiencing these issues on version v4.0.5-2.9.1 (updated 2 days ago).

cimnine commented 3 months ago

It will be when we release a new version of the NB Docker project. (That's the 2.9.1 part of the tag)

lchastel commented 3 months ago

If you need the correction, you could temporary use my image, docker pull ghcr.io/lchastel/netbox-docker:snapshot-2.9.1 I made it 4 days ago, from develop branch.

@cimnine : Could you please check the Github Actions workflow ? (cf https://github.com/netbox-community/netbox-docker/discussions/1258) Except if I made a mistake, the job "Builds new NetBox Docker Images (./build.sh develop, ubuntu-latest)" should create a new image from develop branch and push it as snapshot (or snapshot-2.9.1) ... but the file /opt/netbox/requirements-container.txt is the one from release branche. I checked on latest workflow "Merge pull request #1260 from netbox-community/renovate/sentry-sdk-2.x #1440"
I also pull the latest image with snapshot from dockerhub (docker pull netboxcommunity/netbox:snapshot) sha256:59f03c3086462aea7c435ffb057575ace74098a960cd9567bfd27418bf563102 The image does not contains the file /opt/netbox/requirements-container.txt in version of develop branch.

jonlarsdizparc commented 3 months ago

If you need the correction, you could temporary use my image, docker pull ghcr.io/lchastel/netbox-docker:snapshot-2.9.1 I made it 4 days ago, from develop branch.

Thank you! I'll use it until the next version has been published.