netbox-community / netbox-docker

🐳 Docker Image of NetBox
https://github.com/netbox-community/netbox-docker/wiki
Apache License 2.0
1.81k stars 828 forks source link

feat: added support for netbox_secrets plugin #1264

Closed kuberto773 closed 3 months ago

kuberto773 commented 3 months ago

Related Issue:

New Behavior

Proposed changes enable support for well known plugin "netbox-secrets". ...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Wiki

...

Proposed Release Note Entry

...

Double Check

cimnine commented 3 months ago

Thanks for the PR. We currently don't bundle any plugins by default. Unless a plugin becomes essential to the container or simplifies maintaining the container significantly, we won't consider such PRs.

Bundling plugins by default brings all sorts of challenges, most importantly we would need to validate that the plugin still works with every release of NetBox. Also we'd have to choose which plugins to bundle, as we can't bundle them all or the container will grow significantly in size. Both we don't want.

We have all the infrastructure and documentation in place to guide people how to extend the NetBox image with exactly the plugins that are required. That's as far as we go right now.