search

netbox-community / netbox-floorplan-plugin

NetBox Floorplan plugin
GNU Lesser General Public License v3.0
58 stars 15 forks source link

Support for Netbox 4.0.11 and 4.1.0 #43

Open bogi788 opened 2 months ago

bogi788 commented 2 months ago

Both Netbox 4.0.11 and 4.1.0 have been released this week. The floorplan raises an ImproperlyConfigured exception on both because the maximum version was set to 4.0.10 in https://github.com/netbox-community/netbox-floorplan-plugin/commit/fadfe4428c95654a665f5123e4575bd9152361f6.

FromNetToDev commented 1 month ago

Hello, I got same issue, the problem is that the plugin does not support version 4.1.0 (the maximum supported version is 4.0.10), please consider fixing this

uedvt359 commented 1 month ago

pinning on the patch-level is wrong IMO. There should not be any breakage on patch releases, so this only causes unnecessary delays until a new floorplan release is cut.

darkfritz2 commented 1 month ago

we have already version 4.1.1....

Zheer09 commented 1 month ago

Yes because of this i can not use this plugin it throw that the maximum netbox is 4.0.10 but i have 4.1.0

brandan-schmitz commented 1 month ago

Any update on this? is there any other changes that are needed to make the plugin compatible with Netbox 4.1.x aside from just updating the max version in the setup.py file?

ZachHoiberg commented 1 month ago

In the meantime, you can apply the following to get this running, although I am not sure it is functioning correctly:

  1. Install the floorplan plugin as normal
  2. Modify the max_version in /opt/netbox-X.Y.Z/venv/lib/python3.11/site-packages/netbox_floorplan/__init__.py, replacing X.Y.Z with your version.
  3. cd /opt/netbox
  4. sudo ./venv/bin/python3 netbox/manage.py makemigrations netbox_floorplan_plugin
  5. sudo ./venv/bin/python3 netbox/manage.py migrate
  6. sudo ./venv/bin/python3 netbox/manage.py collectstatic --no-input
  7. sudo systemctl restart netbox netbox-rq
darkfritz2 commented 1 month ago

this is not the "way" but seems to be working...

edit: it's working to install but the module doesnt work. you can't edit anything. set dimensions or stuff like that... so this module doesn't work.

cruse1977 commented 3 weeks ago

Hello, 0.4.1 will support 4.0.11, 0.5.0 will support 4.1 - should be coming next few days

uedvt359 commented 3 weeks ago

great to hear, @cruse1977! but please, please, please don't pin the netbox version on the patch level. most of us would rather risk it partially breaking at runtime, rather than refusing to start up at all.

afaik, the netbox team only introduces breaking changes at the minor level (i.e, y in x.y.z), but never the patch level (i.e, z in x.y.z).

cruse1977 commented 3 weeks ago

great to hear, @cruse1977! but please, please, please don't pin the netbox version on the patch level. most of us would rather risk it partially breaking at runtime, rather than refusing to start up at all.

afaik, the netbox team only introduces breaking changes at the minor level (i.e, y in x.y.z), but never the patch level (i.e, z in x.y.z).

I agree. That NetBox team are good folks ;)

tfboy commented 1 week ago

Hello, 0.4.1 will support 4.0.11, 0.5.0 will support 4.1 - should be coming next few days

Hi Chris, any news on a 0.5.0 version supporting NetBox 4.1.x ? I'm really eager to bring this back into my datacenter. Thanks for this great plugin 🥇