search

netbox-community / netbox-floorplan-plugin

NetBox Floorplan plugin
GNU Lesser General Public License v3.0
37 stars 7 forks source link

Background images not working #5

Open Azmodeszer opened 4 months ago

Azmodeszer commented 4 months ago

Taken from https://github.com/tbotnz/netbox_floorplan/issues/26

There's three inquiries/issues here...

  1. Uploading a background image for locations is giving me a Python error:

'NoneType' object has no attribute 'id'

  1. Uploading a background image for sites is going through, but there is nothing displayed in the floorplan tab. It's the usual blank canvas. I checked the actual file system, the image is there and has the needed Linux permissions. Do images have to meet certain file type and/or size requirements? The documentation didn't say (or I missed it).

  2. When adding (or updating) a floor plan through the Admin page, why is the Tags field required?

Thanks.

Python version: 3.11.2 NetBox version: 3.7.3 netbox_floorplan: 0.4

DanSheps commented 4 months ago

Okay, probably because I don't use floorplan right now, but how do you upload a floor plan?

LOL

Azmodeszer commented 4 months ago

Admin > Floorplans >Select floorplan to change >Background image

DanSheps commented 4 months ago

I didn't have any issue with that workflow using this fork.

helheimcloud commented 3 months ago

Same issue here with Netbox 3.7.3. Is 3.7 unsupported? Any advise would be appreciated.

the-root42 commented 3 months ago

Same issue for me on 3.7.4. Occurs both in my prod and test environment.

bastianleicht commented 2 months ago

Same issue. Has anyone a fix for that?

jeffgdotorg commented 2 months ago

@Azmodeszer have you managed to reproduce this problem using a freshly installed system as your starting point? I want to drive us to a fix but it appears there's some inconsistency in different people's ability to see the problem in action.

DanSheps commented 2 months ago

@Azmodeszer have you managed to reproduce this problem using a freshly installed system as your starting point? I want to drive us to a fix but it appears there's some inconsistency in different people's ability to see the problem in action.

Honestly, we should just move it to the new style admin panel. I think this is an issue with the built-in panel and the way it is leveraged

Azmodeszer commented 2 months ago

@Azmodeszer have you managed to reproduce this problem using a freshly installed system as your starting point? I want to drive us to a fix but it appears there's some inconsistency in different people's ability to see the problem in action.

I have not tried it on a completely fresh install (yet), no. When/if I get around to it, I will post my findings.

cruse1977 commented 1 month ago

I now have the full history of this and whilst the admin panel was there, the javascript code for this was not due to scaling problems and a change in JS library.

I have a version that semi works but with mass scaling issues alongside we'd need to move the upload over to django storage this is potentially a lot of work.