search

netbox-community / netbox-healthcheck-plugin

Apache License 2.0
20 stars 7 forks source link

Packging is broken and not actually installing the source #7

Closed nemith closed 8 months ago

nemith commented 8 months ago

NetBox HealthCheck Plugin version

v0.1.0

NetBox version

N/A

Python version

3.11

Steps to Reproduce

$ python3 -m venv /tmp/test
$ source /tmp/test/bin/activate
$ pip3 install git+https://github.com/netbox-community/netbox-healthcheck-plugin
Collecting git+https://github.com/netbox-community/netbox-healthcheck-plugin
  Cloning https://github.com/netbox-community/netbox-healthcheck-plugin to /private/var/folders/xv/k7lms_fn08972kd179h5j1zr0000gp/T/pip-req-build-tgg2i7l4
  Running command git clone --filter=blob:none --quiet https://github.com/netbox-community/netbox-healthcheck-plugin /private/var/folders/xv/k7lms_fn08972kd179h5j1zr0000gp/T/pip-req-build-tgg2i7l4
  Resolved https://github.com/netbox-community/netbox-healthcheck-plugin to commit cc9c794a070e896dd2f6a3bef4cd67e64e8a59d2
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting django-health-check<4,>=3 (from netbox-healthcheck-plugin==0.1.0)
  Downloading django_health_check-3.17.0-py2.py3-none-any.whl (29 kB)
Collecting django>=2.2 (from django-health-check<4,>=3->netbox-healthcheck-plugin==0.1.0)
  Downloading Django-4.2.7-py3-none-any.whl.metadata (4.1 kB)
Collecting asgiref<4,>=3.6.0 (from django>=2.2->django-health-check<4,>=3->netbox-healthcheck-plugin==0.1.0)
  Downloading asgiref-3.7.2-py3-none-any.whl.metadata (9.2 kB)
Collecting sqlparse>=0.3.1 (from django>=2.2->django-health-check<4,>=3->netbox-healthcheck-plugin==0.1.0)
  Downloading sqlparse-0.4.4-py3-none-any.whl (41 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 41.2/41.2 kB 2.9 MB/s eta 0:00:00
Downloading Django-4.2.7-py3-none-any.whl (8.0 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 8.0/8.0 MB 17.2 MB/s eta 0:00:00
Downloading asgiref-3.7.2-py3-none-any.whl (24 kB)
Building wheels for collected packages: netbox-healthcheck-plugin
  Building wheel for netbox-healthcheck-plugin (pyproject.toml) ... done
  Created wheel for netbox-healthcheck-plugin: filename=netbox_healthcheck_plugin-0.1.0-py3-none-any.whl size=6286 sha256=23416d96efce7c467b42308db7c21ffdb89a0d7d156ab8d4007b2836d1ec8a1d
  Stored in directory: /private/var/folders/xv/k7lms_fn08972kd179h5j1zr0000gp/T/pip-ephem-wheel-cache-vdany5p6/wheels/b8/ac/24/cd5f72224c71ac49d9593211322a50ee0e70f932c5cb033623
Successfully built netbox-healthcheck-plugin
Installing collected packages: sqlparse, asgiref, django, django-health-check, netbox-healthcheck-plugin
Successfully installed asgiref-3.7.2 django-4.2.7 django-health-check-3.17.0 netbox-healthcheck-plugin-0.1.0 sqlparse-0.4.4
$ python3
Python 3.11.6 (main, Nov  2 2023, 04:39:43) [Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import netbox_healthcheck_plugin
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'netbox_healthcheck_plugin'
>>> import sys
>>> sys.path
['', '/opt/homebrew/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python311.zip', '/opt/homebrew/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11', '/opt/homebrew/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/lib-dynload', '/private/tmp/test/lib/python3.11/site-packages']
>>> ^D
$ ls /private/tmp/test/lib/python3.11/site-packages
Django-4.2.7.dist-info/  _distutils_hack/  asgiref/  asgiref-3.7.2.dist-info/  distutils-precedence.pth  django/  django_health_check-3.17.0.dist-info/  health_check/  netbox_healthcheck_plugin-0.1.0.dist-info/  pip/  pip-23.3.1.dist-info/  pkg_resources/  setuptools/  setuptools-68.2.2.dist-info/  sqlparse/  sqlparse-0.4.4.dist-info/

Expected Behavior

There should be a netbox_healthcheck_plugin folder in site packages and import netbox_healthcheck_plugin shouldn't raise an exception.

Observed Behavior

No source code installed. Only meta data on the package available. This happens with the latest commits but also with the package published to pypi.