search

netbox-community / netbox-reorder-rack

NetBox plugin to allow users to reorder devices within a rack using a drag and drop UI.
Apache License 2.0
36 stars 4 forks source link

Unracked devices are labeled "None" #21

Open llamafilm opened 1 week ago

llamafilm commented 1 week ago

netbox-reorder-rack version

v1.1.1

Python version

3.12

Steps to Reproduce

  1. Create a new rack
  2. Add 1 or more devices to the rack without a position
  3. Click reorder rack

Expected Behavior

It should show the same label as the /dcim/racks/xxx page and respect the labels vs images preference.

Observed Behavior

All the unracked devices are labeled "None" so it's impossible to identify them

image
llamafilm commented 1 week ago

After further review, it looks like this issue only happens when the device is unnamed.

cruse1977 commented 1 week ago

Possible requirement for ability to cope with empty device names, however what field could be used as an identifier - ID is obvious but does not help usability; description would be potentially be too long.

llamafilm commented 1 week ago

For consistent user experience, I would expect this to work the same as other rack elevation views, where it shows the device description.

There is an open FR for custom labels. If this gets implemented, I would hope it applies here too. https://github.com/netbox-community/netbox/issues/14205

Azmodeszer commented 1 week ago

NetBox normally shows the Device Type name for unnamed devices in the rack elevation view.

llamafilm commented 1 week ago

Oops, yes that’s what I meant.