netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Public demo: https://demo.netbox.dev
http://netboxlabs.com/oss/netbox/
Apache License 2.0
15.68k stars 2.53k forks source link

Show 'asset_tag' in the rack view #12518

Closed PieterL75 closed 11 months ago

PieterL75 commented 1 year ago

NetBox version

v3.4.10

Feature type

Data model extension

Proposed functionality

Add 'Asset tag' to the dropdown of the 'rack view' image

Use case

In our datacenter, we only have the assettags labeled on the devices, not the hostnames. Currently we can see the assettag if we 'hover' over the name of the device, but it would be better to see the asset in the view direct

Database changes

No response

External dependencies

No response

PieterL75 commented 1 year ago

I have a Branch ready that will implement this feature. https://github.com/PieterL75/netbox/tree/issue12518_addassettagtorackview can I create a PR for review ?

jeremystretch commented 1 year ago

This probably isn't something we can support without the introduction of a customization mechanism for the device label. It wouldn't make sense to add "asset tags" as an alternative directly to the images/labels dropdown.

PieterL75 commented 1 year ago

The Assettag is the unique physical identifier of an Asset. The little sticker (actually a pretty big one on front and back) that we put on the device, to identify it in the datacenter, without the burden of (changing) naming standards. Having a RackView with Assettag is pretty logical to me..

The PR I have takes care of that, and provides 2 means of creating that view

That allows us to get that view in automation and in the gui

Pieter

PieterL75 commented 1 year ago

@jeremystretch Shall I submit the PR ? then you can review how it works. This FR will only add an extra view pane to the racks, nothing more.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

github-actions[bot] commented 11 months ago

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

PieterL75 commented 11 months ago

Can this be reviewed again ? I would very much like to see that 'asset_tag' as labels in the view, rather than the 'devicename' In our datacenters, the physical world works only with 'asset tags' and not with devicenames.