netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Public demo: https://demo.netbox.dev
http://netboxlabs.com/oss/netbox/
Apache License 2.0
15.43k stars 2.51k forks source link

Add "IEC 60130-10" (DC) to power port types #14010

Open ZPrimed opened 9 months ago

ZPrimed commented 9 months ago

NetBox version

v3.6.3

Feature type

Data model extension

Proposed functionality

The existing model for "power ports" includes a very large amount of AC-type ports, but not much in the way of DC power. It would be nice to have better documentation about what specific type of connector(s) a device has.

I would like to propose these additions:

Use case

Attempting to correctly model real-world equipment requires the port types to be defined. 😉

Database changes

(no db changes expected?)

External dependencies

No response

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

jeffgdotorg commented 5 months ago

@ZPrimed this issue is at risk of being auto-closed, and I think it would be a shame if that happened, so I'm using my privilege to give it a bump and asking for a little more detail in the form of a list of specific connector type enum IDs, descriptive names, and slug names that you propose to add. You might refer to PR #8415 to get an idea of what we're looking for.

ZPrimed commented 5 months ago

Well, at a bare minimum, the IEC 60130-10 standard coaxial/barrel connectors should probably be included as sub-types of "DC":

Coaxial Barrel - IEC 60130-10

A generic "Other Barrel Plug" would probably be a useful catch-all as well...

A design question: The current power connector list never seems to go below one "level". Would there be any objection to having a "sub-heading" below "DC" of "Coaxial Barrel - IEC 60130-10" and then listing out the individual "types" below that sub-heading?

Additionally, is it "redundant" to include "DC" as part of the description for the connector, since that is already included in the heading above it?

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

arthanson commented 2 months ago

Note: This would be an addition to dcim.choices.PowerPortTypeChoices

arthanson commented 1 month ago

@ZPrimed can you please look at PR #16206 see if that would address your request?

ZPrimed commented 1 month ago

Looks great to me. A couple of those do have a positive-retention (screw-down) variant, wasn't sure if those should be included as well? IMO it's always useful to know if a connector is capable of "locking"...

arthanson commented 3 weeks ago

@ZPrimed do you know the other side (female) of these connectors? We need both sides to be added for these, taking a Quick Look at the specs I didn't see these defined.

github-actions[bot] commented 2 weeks ago

This is a reminder that additional information is needed in order to further triage this issue. If the requested details are not provided, the issue will soon be closed automatically.

ZPrimed commented 2 weeks ago

@ZPrimed do you know the other side (female) of these connectors? We need both sides to be added for these, taking a Quick Look at the specs I didn't see these defined.

@arthanson I've never heard of anything beyond simply "male" and "female" for these plugs & jacks. They get described by the ID/OD and inner pin size.

eronlloyd commented 1 week ago

I don't have the specs handy, but this article seems to reference quite a few based on the IEC 60130-10:1971, EIAJ (Japan), and DIN (Germany). The Wikipedia article seems to be more detailed, as well.