netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
15.79k stars 2.54k forks source link

Problem to restore configuration from history #16400

Closed ravenrs closed 3 months ago

ravenrs commented 3 months ago

Deployment Type

NetBox Cloud

NetBox Version

v4.0.4

Python Version

3.10

Steps to Reproduce

2024-06-04_14-46-12

  1. Click https://demo.netbox.dev/core/config-revisions/
  2. Create new configuraton
  3. Delete active configuration
  4. Click to restore the previous configuration
  5. Get error messageconfiguration

Expected Behavior

previous configuration should be restored.

Observed Behavior

error was raised.

arthanson commented 3 months ago
Internal Server Error: /core/config-revisions/3/restore/
Traceback (most recent call last):
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/dev/work/netbox/netbox/utilities/views.py", line 58, in dispatch
    return super().dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/dev/work/netbox/netbox/core/views.py", line 227, in get
    current_config.data.get(param.name, None),
    ^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'data'
Internal Server Error: /core/config-revisions/3/restore/
Traceback (most recent call last):
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/dev/work/netbox/netbox/utilities/views.py", line 58, in dispatch
    return super().dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/.pyenv/versions/3.12.3/lib/python3.12/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ahanson/dev/work/netbox/netbox/core/views.py", line 227, in get
    current_config.data.get(param.name, None),
    ^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'data'
Julio-Oliveira-Encora commented 3 months ago

Could you please assign it to me?