search

netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
16.16k stars 2.59k forks source link

Cannot save Bulk Edit Selected Objects with HTMX nav enabled #16675

Open redbob365 opened 4 months ago

redbob365 commented 4 months ago

Deployment Type

Self-hosted

NetBox Version

v4.0.5

Python Version

3.10

Steps to Reproduce

  1. Enable HTML Navigation in user settings
  2. Selected some items (Device Types);
  3. Clicked yellow button "Edit Selected";
  4. Set "Is full depth" to No (all selected before was set to Yes)
  5. Nothing happens

Expected Behavior

"Is full depth" should be changed to "No" in selected items

Observed Behavior

Nothing happened, the form doesn't even appear to submit, fields therefore are not updated

PS:

Works correctly with HTMX navigation disabled per default.

jeffgdotorg commented 4 months ago

Thanks for reporting a problem you're having with NetBox.

I did not manage to reproduce the problem using the provided Steps to Reproduce in a fresh install of NetBox v4.0.5. It's maybe worth noting that the only objects I created in an otherwise empty system are the manufacturer and device types.

The following video shows my UI interactions. Besides the flow shown in which I select 2 of the 4 existing device types for a bulk edit, I also tried a variation in which I used the Select All checkbox in the column header, but the result was the same, behaved as expected.

https://github.com/netbox-community/netbox/assets/1209268/da4c797f-d30c-4b7d-94ab-f1dff29bca18

If you're able to arrive at a reliable set of steps to reproduce that starts with a freshly installed, empty system, please update your issue body accordingly.

redbob365 commented 4 months ago

Here is what I've done. Same error Gravação de tela de 21-06-2024 13:02:57.webm

As I said, I did un upgrade from 3.7.3 to 4.0.5

redbob365 commented 4 months ago

The same occurs when I tried to delete selected items: Gravação de tela de 21-06-2024 13:09:12.webm

redbob365 commented 4 months ago

I discovered the cause of this issue:

After the upgrade, I had enabled HTMX Navigation. So I disabled back this attribute and everything worked! image_2024-06-21_143934302

jeffgdotorg commented 4 months ago

Thanks for the revisions. I've confirmed in the lab and updated your original issue body accordingly.

I'm moving your issue to needs owner status. If you or another developer with the requisite skills and capacity would like to work it through to a PR, please say so and a maintainer will assign the issue to you.

arthanson commented 1 month ago

blocked by. #17571