netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Public demo: https://demo.netbox.dev
http://netboxlabs.com/oss/netbox/
Apache License 2.0
15.49k stars 2.52k forks source link

editing selection of devices via quick search #16733

Open GeertReijnders opened 1 month ago

GeertReijnders commented 1 month ago

Deployment Type

Self-hosted

NetBox Version

v4.0.5

Python Version

3.12

Steps to Reproduce

  1. Click on devices

  2. type your searchwords in quick search

  3. click Select all ... devices matching query image

  4. click edit selected devices

  5. At the left upper corner you will see another amount of devices which are going to be edited. In the selected devices tab you will see other devices selected than you searched for. image

Expected Behavior

I would expect that only the devices I searched for should be edited.

Observed Behavior

All devices were selected.

jeremystretch commented 1 month ago

The bulk form target URL needs to be updated when the quicksearch value is updated, to ensure that ?q=foo is passed along as a query parameter to the bulk edit/delete view.

Julio-Oliveira-Encora commented 4 weeks ago

Could you please assign it to me?

arthanson commented 2 weeks ago

Issue is in object_list.html the bulk-edit buttons are outside the table htmx so request.GET is the original page params and not from the htmx updates.