search

netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
15.81k stars 2.54k forks source link

Add ability to add contacts to multiple contact groups #17170

Open arosemanhellmann opened 1 month ago

arosemanhellmann commented 1 month ago

NetBox version

v4.0.5

Feature type

Data model extension

Proposed functionality

Currently it's only possible to add a contact (person) to one contact group. In our organiszation this does not work out well, as we have only few persons where this 1:1 relation would work. Most of our IT Staff works in multiple (contact)groups. As what i know, in the admin part it's possible (access groups) it's possible to add persons to multipl groups.

It would be nice to have this abbility also in the contact groups.

Use case

Build the source organizational structure in the contacts / contact groups, what currently is not possible for us.

Database changes

No response

External dependencies

No response

goteamkor commented 1 month ago

literally asked for the same thing 5 days ago. https://github.com/netbox-community/netbox/issues/17123

glad this will hopefully get some traction. @jeremystretch, this being categorized as a breaking change .. does that mean 4.0 to 4.1? or perhaps a point release like 4.1 to 4.1.1 ?

I guess I'm asking if it doesn't go into 4.1 .. would we have to wait until 4.2?

arosemanhellmann commented 1 month ago

https://github.com/netbox-community/netbox/issues/17123 does also focus on sites and site groups / not sure if this is tecnically the same. I'm only focusing on Contacts and Contact Groups. Just wanted to let you know. As what i read above you're planning a change here.

goteamkor commented 1 month ago

17123 does also focus on sites and site groups / not sure if this is tecnically the same. I'm only focusing on Contacts and Contact Groups. Just wanted to let you know. As what i read above you're planning a change here.

I included site groups because the overall concept is the same. The concept is allowing an object to be part of multiple groups of that objects group type.

sites in multiple site groups contacts in multiple contact groups

the point was consistency. Especially since the documentation outlines site groups as 'role or function' without recognizing that a site or a contact can serve multiple roles or functions. I outlined some examples in https://github.com/netbox-community/netbox/issues/17123.

While sites in multiple site groups would be handy too, if I had to choose, I'd choose contacts being in multiple contact groups. I also think implementing this would flow nicely into my other FR https://github.com/netbox-community/netbox/issues/17050 which would see the ability to assign contact groups to objects instead of just contacts.

This way, if you are able to place a contact into multiple groups, and then assign contact groups to objects you can much more easily reflect how most companies actually work. (switches having a team assigned as a technical contact, etc.)