search

netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
16.34k stars 2.6k forks source link

Add additional tunnel encapsulation choices: PPTP, L2TP, EoIP, SSTP #17960

Open jmcguir opened 2 weeks ago

jmcguir commented 2 weeks ago

NetBox version

v4.1.4

Feature type

Change to existing functionality

Triage priority

I volunteer to perform this work (if approved)

Proposed functionality

I'd like to add PPTP, L2TP, and EoIP as Tunnel Encapsulation Choices. PPTP, and L2TP are standards based tunnel protocols while EoIP is a MikroTik proprietary protocol and SSTP is a Microsoft proprietary protocol.

PPTP: https://datatracker.ietf.org/doc/html/rfc2637
L2TP: https://datatracker.ietf.org/doc/html/rfc2661 EoIP: https://help.mikrotik.com/docs/spaces/ROS/pages/24805521/EoIP SSTP: https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-sstp/c50ed240-56f3-4309-8e0c-1644898f0ea8

As far as I can tell the only change here would be to add these fourto the choices.py here: https://github.com/netbox-community/netbox/blob/develop/netbox/vpn/choices.py

Use case

This lets users model more accurately their VPN tunnels. Right now the choices don't have an other so you have to use an incorrect Encapsulation choice.

Database changes

No response

External dependencies

No response

chbally commented 2 weeks ago

Please also add WireGuard: WireGuard: https://datatracker.ietf.org/doc/html/rfc8922#name-wireguard and if possible OpenVPN: OpenVPN: https://datatracker.ietf.org/doc/html/rfc8922#name-openvpn

I think even if is kind of IP in IP lots of people would appreciate these two protokolls in Netbox: https://github.com/netbox-community/netbox/discussions/14683

jmcguir commented 1 week ago

If approved I'd be happy to add WireGuard and OpenVPN to a PR I'm willing to write.