Fixes: #18037 - Bound VLANGroup VLAN ID max by `VLAN_VID_MAX`

netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/

http://netboxlabs.com/oss/netbox/

Apache License 2.0

16.33k stars 2.6k forks source link

Fixes: #18037 - Bound VLANGroup VLAN ID max by `VLAN_VID_MAX` #18041

Closed DanSheps closed 1 day ago

DanSheps commented 3 days ago

Fixes: #18037 - Restrict VLANGroup VID max to 4094

Bound VLANGroup VLAN ID max by VLAN_VID_MAX

DanSheps commented 3 days ago

To be clear, this does not fix the list issue, I am not sure where that code is going to come into play (Checked the annotation on the custom queryset and the table and nothing there looks to cause any issues), however this does prevent VID's > 4094 from being created.

It is likely in ranges_to_strings() from vid_ranges_list but changing that may have unintended impacts.