netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
16.27k stars 2.59k forks source link

Counting is off when mass deleting regions #2102

Closed bdlamprecht closed 6 years ago

bdlamprecht commented 6 years ago

Issue type

[X] Bug report

Environment

Description

When deleting large numbers of regions via the WebUI, the displayed "number" is not accurate between pages of the same process.

Steps to recreate:

  1. Have a large number of regions that need to be deleted, my example uses 500.
  2. Follow the steps 1, 2, and 3 in screenshot A.
  3. You are then presented a page with the "count" of proposed regions to be deleted set at 100 in screenshot B.
  4. Scroll to the bottom of that page and perform step 4 in screenshot C.
  5. The result is that actually 104 regions were deleted as shown in screenshot D and E.

I have not gone through the details of what additional sites are deleted between the 100 that were confirmed and the 104 that were actually deleted, but I'm hoping it is something fairly straightforward to fix. Also, perhaps the initial page showing that all 500 are going to be deleted can be fixed as well, as that is not what actually happens.

Let me know if you need other details.

Thanks again for the greatness that is NetBox!

Screenshot A: image

Screenshot B: image

Screenshot C: image

Screenshot D: image

Screenshot E: image

jeremystretch commented 6 years ago

This is such a thorough and well-written bug report I actually hate to tell you that this was just fixed yesterday under #2097. It should be working normally under the develop branch and the fix will be included in v2.3.4. Closing this out but please ask to re-open if I've missed something.