search

netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
16.02k stars 2.57k forks source link

Markdown Tables Broke Somewhere in the 2.7 train #4343

Closed ryanmerolle closed 4 years ago

ryanmerolle commented 4 years ago

Environment

Steps to Reproduce

Insert a table using the example markdown netbox references in https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#tables

All other Markdown seems to render

It worked in 2.6 train, and I am pretty sure it worked earlier in 2.7 train.

Expected Behavior

Render the table:

Tables Are Cool
col 3 is right-aligned $1600
col 2 is centered $12
zebra stripes are neat $1

Observed Behavior

Shows the markdown code as one line & does not render:

| Tables | Are | Cool || ------------- |:-------------:| -----:|| col 3 is | right-aligned | $1600 || col 2 is | centered | $12 || zebra stripes | are neat | $1 |

ryanmerolle commented 4 years ago

I personally use tables to show inventory of spares at a site that are not in a rack like cables and sfps

jeremystretch commented 4 years ago

We ditched py-gfm in NetBox v2.7.10 because it was pinning Markdown to a very old release (v2.6.11) and no longer appears to be maintained. The inclusion of the admonition and fenced_code extensions were meant to maintain feature parity for our purposes but it appears support for tables was overlooked.

I was under the impression tables were included in core, but it looks like we have to enable an extension for them.