search

netbox-community / netbox

The premier source of truth powering network automation. Open source under Apache 2. Try NetBox Cloud free: https://netboxlabs.com/free-netbox-cloud/
http://netboxlabs.com/oss/netbox/
Apache License 2.0
16.15k stars 2.58k forks source link

Rename optic type 128gfc-sfp28 to 128gfc-qsfp28 (Fibrechannel) #7589

Closed suom1 closed 2 years ago

suom1 commented 3 years ago

NetBox version

v3.0.7

Python version

3.8

Steps to Reproduce

Currently the 128G FC optic type is named 128gfc-sfp28, which is wrong as it's not a SFP28 formfactor but a QSFP28.

Expected Behavior

The optic type should be 128gfc-qsfp28 to be correct with the type of optic it is.

Observed Behavior

Problem was noticed when working on netbox-community/devicetype-library#503.

jeremystretch commented 2 years ago

I'm going to bump this to v3.1.0 since the corrected value effects a breaking change.