search

netbox-community / pynetbox

Python API client library for Netbox.
Apache License 2.0
538 stars 165 forks source link

Add Python 3.12 in tests and other lists #601

Open markkuleinio opened 6 months ago

markkuleinio commented 6 months ago

Fixes: #600

Added Python 3.12 in tests, setup.py classifiers and in the bug report forms.

markkuleinio commented 6 months ago

I did not change .readthedocs.yaml yet, I guess that's just for building the docs, maybe that can be done later.

markkuleinio commented 6 months ago

I don't know how to fix the failing tests, @abhi1693

Container pytest_pynetbox_1704357384-netbox_v3_3_netbox-housekeeping-1 Created Error response from daemon: failed to mkdir /var/lib/docker/volumes/pytest_pynetbox_1704357384_pytest_pynetbox_v3_3_netbox-media-files/_data/image-attachments: mkdir /var/lib/docker/volumes/pytest_pynetbox_1704357384_pytest_pynetbox_v3_3_netbox-media-files/_data/image-attachments: file exists

abhi1693 commented 6 months ago

It's possible that 3.12 was not supported with older netbox versions.

markkuleinio commented 6 months ago

It's possible that 3.12 was not supported with older netbox versions.

Why would that be shown as a docker volume creation error? (Sorry, I'm not a dockerist)

markkuleinio commented 6 months ago

I'll still try with NetBox 3.7 only, just a minute

(update: it worked)

markkuleinio commented 6 months ago

Added NetBox 3.3. I don't see the logic: now it failed the Python 3.8 + NetBox 3.3 test. Something is wrong in the docker logic, cannot help that. Restoring the original changes now

markkuleinio commented 6 months ago

Looks like the docker image for NetBox 3.3 is not working, others are fine, including tests with Python 3.12.