search

netbox-community / pynetbox

Python API client library for Netbox.
Apache License 2.0
580 stars 172 forks source link

Relax upper limit of packaging version #608

Closed frenzymadness closed 3 months ago

frenzymadness commented 8 months ago

It seems to me that pynetbox should work with packaging 24 but I'm not able to run all tests because I don't have docker installed.

frenzymadness commented 8 months ago

It builds fine in Fedora Linux with packaging 24.0

markkuleinio commented 8 months ago

If I looked it correctly, packaging is only used for version. To be honest, I find it to be such a simple use and core function of packaging that I don't think it needs any kind of version number pinning.

frenzymadness commented 8 months ago

If I looked it correctly, packaging is only used for version. To be honest, I find it to be such a simple use and core function of packaging that I don't think it needs any kind of version number pinning.

That sounds even better from my point of view. Should I update this PR?

markkuleinio commented 8 months ago

I'd say so yes.

frenzymadness commented 8 months ago

Done and force-pushed.

gaige commented 5 months ago

I'd appreciate seeing this one accepted.

I am not sure if others are encountering this, but the <24.0 requirement is causing some difficulties in aligning with code that I'm using that wants packaging 24.x.