API token is passed to retrieve NetBox version

netbox-community / pynetbox

Python API client library for Netbox.

Apache License 2.0

578 stars 172 forks source link

API token is passed to retrieve NetBox version #641

Open Kani999 opened 2 months ago

Kani999 commented 2 months ago

Fixes: #640

Updated the version property in pynetbox/core/api.py to pass the API token when calling get_version.
No problem raised even if the token is None
This change addresses the issue where nb.version returns an empty string when using an OIDC proxy, due to unauthorized requests being redirected to the login page.

Closes #640

rondemena commented 2 months ago

It was not my intent to trigger git checks and move to the next step but to bring relevance to the fix is desired in other places and reinforce the proposed change, apologies to the maintainers.

mmauksch commented 2 months ago

someone correct me if I'm wrong but isn't this already addressed and merged in #616 I've stumbled over the same problem regarding https://github.com/netbox-community/Device-Type-Library-Import/issues/134

Kani999 commented 2 months ago

someone correct me if I'm wrong but isn't this already addressed and merged in #616 I've stumbled over the same problem regarding netbox-community/Device-Type-Library-Import#134

I don't think so. With our specific configuration, where a redirect occurs when the user is not authorized, it won't trigger a 403 error.

TonkSlip commented 1 month ago

I have the same issue, and I need this fix too

manuelrais commented 2 weeks ago

Hi
Same here, any idea when this request will be merged ? :)