netboxlabs / diode

Diode data ingestion for NetBox, from NetBox Labs
https://netboxlabs.com
Other
36 stars 1 forks source link

feat: OBS-489 - allow change tls verification by setting env variable #127

Closed leoparente closed 3 months ago

linear[bot] commented 3 months ago
OBS-489 Allow users to disable http.client TLS verify

In the reconciler service, add option to disable TLS verify for the HTTP client used for communication with NetBox API. NetBoxAPI client: [https://github.com/netboxlabs/diode/tree/develop/diode-server/netboxdiodeplugin](https://github.com/netboxlabs/diode/tree/develop/diode-server/netboxdiodeplugin) Example: ```golang tr := &http.Transport{ TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, } client := &http.Client{Transport: tr} ``` `InsecureSkipVerify` should be configurable via environment variable with [config](https://github.com/netboxlabs/diode/blob/develop/diode-server/reconciler/config.go) and default to false.

github-actions[bot] commented 3 months ago
Go test coverage STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/ingester 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.21s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 8.5% 21 0 0
🟢 PASS 1.05s github.com/netboxlabs/diode/diode-server/reconciler 1.2% 1 0 0
🟢 PASS 1.22s github.com/netboxlabs/diode/diode-server/reconciler/changeset 81.7% 58 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 81.6% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 71.3%

orb-ci commented 3 months ago

:tada: This issue has been resolved in version 0.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

orb-ci commented 3 months ago

:tada: This issue has been resolved in version 0.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: